Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apparent emitter brightness #3

Conversation

Peregrine05
Copy link

  • Changed Emitter intensity to scale both emitter light intensity and apparent emitter brightness. Changed its default value to 1.
  • Added Emitter light intensity, which scales only the emitter light intensity. Its default value is 13, to reflect the default value of Emitter intensity from previous versions.
  • Added Apparent emitter brightness, which scales only the apparent brighness of emitters. Its default value is 1.
  • Added an Apparent brightness material property, which changes the apparent brightness of the material when it behaves as an emitter. Its default value is 1
  • When loading scenes saved in an older Chunky version, Chunky will load the value of Emitter intensity as the value of Emitter light intensity, and set Emitter intensity to 1.

New:
image
image

Peregrine05 and others added 6 commits February 23, 2023 11:19
It was accidentally removed.
- Change `Emitter intensity` to scale both emitter light intensity and apparent emitter brightness.
- Add `Emitter light intensity`, which scales only the emitter light intensity.
"looks like firstReflection is only used for fog, but yeah don't want to mess with our jank xd" (NotStirred, [Discord](https://discord.com/channels/541221265512464394/545374333883777037/1079435203879129220))

Co-Authored-By: Tom Martin <[email protected]>
@JustinTimeCuber
Copy link
Owner

I feel like some of the code (specifically in PathTracer) is a bit more complicated than it needs to be; I'll try to find time to look at it in more detail this week.

@Peregrine05
Copy link
Author

I moved this to chunky-dev#1555.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants