Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/tony/payment/user-billing-pay #98

Merged
merged 9 commits into from
Oct 12, 2023
Merged

Feature/tony/payment/user-billing-pay #98

merged 9 commits into from
Oct 12, 2023

Conversation

TonyKim9401
Copy link
Contributor

해결하려는 문제가 무엇인가요?

  • 운전자가 trip 테이블 내용을 PAY_REQUEST로 요청하면 사용자가 요금을 지불하고 PAY_COMPLETE로 변경한다

어떻게 해결했나요?

  • 기 등록된 빌링정보로 결제 진행

    • 성공 케이스
      • 사용자가 기등록한 결제 정보를 사용하여 요금을 지불한다
    • 실패 케이스
      • 기 등록된 결제 수단이 하나도 없다

Attachment

@TonyKim9401
update: tripReader 수정
5ddce52 
userId와 tripId로 조회 하는 메서드 추가
@TonyKim9401
update: BillingService & Test 추가
0e5a49f 
구체적인 상세 기능은 많이 없습니다.
@TonyKim9401
update: BillingService에서 trip 상태코드 확인
215799f 
trip 상태코드 검증
@TonyKim9401
add: TripController 생성
5466b47 
택시기사가 [운행 완료]시 사용자에게 결제 요구하면 결제 진행하는 API
@github-actions
Copy link

github-actions bot commented Oct 11, 2023 •
edited
Loading

Test Results

40 tests   38 ✔️  10s ⏱️
  7 suites    2 💤
  7 files      0 ❌

Results for commit 8c41d8b.

♻️ This comment has been updated with latest results.

@JangHyeonJun2
Copy link
Contributor

이 건은 해결되서 PR Close 하도록하겠습니닷.

@JangHyeonJun2
Copy link
Contributor

혹시 Close해도 괜찮을까용?

@TonyKim9401
update: BillingServiceTest
177de29
@TonyKim9401
Merge remote-tracking branch 'origin/feature/tony/payment/user-billin…
bb73a10 
…g-pay' into feature/tony/payment/user-billing-pay

# Conflicts:
#	src/test/kotlin/com/hh2/katj/payment/service/BillingServiceTest.kt
@TonyKim9401
update: BillingServiceTest
8c41d8b
@TonyKim9401 TonyKim9401 temporarily deployed to dev October 12, 2023 03:21 — with GitHub Actions Inactive
@TonyKim9401
Copy link
Contributor Author

📝 테스트 커버리지 리포트입니다

File Coverage [72.78%] ❌
PaymentMethodService.kt 94.33% 🍏
BillingService.kt 91.23% 🍏
RequestAddCard.kt 72.09% ❌
ResponsePaymentMethod.kt 61.17% ❌
PaymentMethod.kt 55.44% ❌
TripReader.kt 43.59% ❌
TripController.kt 42.86% ❌
Total Project Coverage 69.83% 🍏

@TonyKim9401 TonyKim9401 merged commit 5fe932e into dev Oct 12, 2023
3 checks passed
@TonyKim9401 TonyKim9401 temporarily deployed to dev October 12, 2023 06:06 — with GitHub Actions Inactive
@TonyKim9401 TonyKim9401 temporarily deployed to dev October 12, 2023 06:09 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JangHyeonJun2 JangHyeonJun2 JangHyeonJun2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TonyKim9401 @JangHyeonJun2