Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: some suggestions for repo setup #12

Merged
merged 4 commits into from
May 29, 2024
Merged

chore: some suggestions for repo setup #12

merged 4 commits into from
May 29, 2024

Conversation

rflechtner
Copy link
Contributor

Generally looking good to me, what the different functions are for is not immediately obvious to me, so I'll stick to general things:

  • When using the yarn version plugin we can upgrade to yarn version 4 which has promoted that plugin to a builtin
  • We could maybe just use the tsconfig.json as the base, reducing the number of files
  • On the topic of release strategies: I'd recommend using a deferred version bump (you want a patch release rn, if I got that right) on a feature branch, and then running yarn version apply and committing as part of the actual release on the main branch. That's how we have it set up for the jcs repo for example.
  • If you want to export types separately from the root (their already included in star exports anyway) it's probably better to not re-export function declarations as well; so in the types.ts files you'd have to do selective exports of types instead.

@ntn-x2 ntn-x2 merged commit 8de358b into main May 29, 2024
1 check passed
@ntn-x2 ntn-x2 deleted the rf-suggestions branch May 29, 2024 13:42
ntn-x2 pushed a commit that referenced this pull request May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants