refactor: messaging #18

Ad96el · 2023-08-04T12:11:21Z

fixes https://github.com/KILTprotocol/ticket/issues/2715

I only included the message types which are defined in the kilt extension spec. I double-checked it, but I do not want to roll out that I forgot one type. 😄

rflechtner

Copying all the type definitions seems a little much, what's the reason for that?

src/messaging/index.ts

src/types/Address.ts

src/tests/jest.setup.ts

src/messaging/index.ts

weichweich

I would like to see a bit more documentation

src/types/Terms.ts

src/types/Quote.ts

src/types/Message.ts

src/tests/utils.ts

src/types/Message.ts

src/messaging/CredentialApiMessageTypes.ts

src/tests/messageUtils.ts

src/types/Quote.ts

weichweich

Just a few minor things

weichweich · 2023-08-11T05:47:50Z

src/tests/messageUtils.ts

+
+
+
+


Too many whitespace

Suggested change

It is removed in: d2627c3.

I also added a small GitHub action to check the fmt. I think this is useful since the project gets still more features.

src/tests/messageUtils.ts

src/types/Message.ts

arty-name · 2023-08-14T08:34:29Z

tsconfig.json

@@ -11,7 +11,7 @@
    // "disableReferencedProjectLoad": true,             /* Reduce the number of projects loaded automatically by TypeScript. */

    /* Language and Environment */
-    "target": "ES2022",                                  /* Set the JavaScript language version for emitted JavaScript and include compatible library declarations. */
+    "target": "ES2022" /* Set the JavaScript language version for emitted JavaScript and include compatible library declarations. */,


What is this style called? 😱

Ah, funny. It's using the Prettier style guide. However, I wasn't aware of how it would format JSON with comments. It doesn't really appear beautiful.

weichweich

Could we move the CI pipeline for style checks and the license header to a different PR? this is already big enough as it is,

Ad96el · 2023-08-14T11:07:12Z

I created two new PR. one for the fmt and the second for the license.

src/messaging/CredentialApiMessageType.ts

rflechtner

I got a few suggestions on what we should and shouldn't expose, but looks very good otherwise!

src/messaging/utils.ts

src/messaging/MessageEnvelope.ts

src/messaging/index.ts

src/index.ts

Co-authored-by: Raphael Flechtner <[email protected]>

rflechtner

soooo close 😬

src/messaging/index.ts

src/messaging/utils.ts

rflechtner

Amaaaaaaazing! Nice work

rflechtner · 2023-10-02T13:30:51Z

@weichweich if you don't have any more complaints here we would merge this soon

weichweich

More Complaints...

Ad96el added 3 commits August 4, 2023 09:46

copy all types

40301e9

integrated messaging

e6d2f3d

with messaging

f442317

Ad96el changed the title ~~Refactor/messaging~~ refactor: messaging Aug 4, 2023

Ad96el added 4 commits August 4, 2023 14:52

with quote

0ab879c

fix: make exportable

7008be2

fix: test against latest not develop

5bb1159

fix: test against latest not develop

819d315

Ad96el requested a review from rflechtner August 7, 2023 14:37

Ad96el marked this pull request as ready for review August 7, 2023 14:39

Ad96el requested a review from weichweich August 7, 2023 14:39

rflechtner reviewed Aug 7, 2023

View reviewed changes

src/messaging/index.ts Outdated Show resolved Hide resolved

src/messaging/index.ts Outdated Show resolved Hide resolved

src/types/Address.ts Outdated Show resolved Hide resolved

src/tests/jest.setup.ts Outdated Show resolved Hide resolved

src/messaging/index.ts Show resolved Hide resolved

Ad96el added 2 commits August 8, 2023 09:44

refactor: reduce types

dcc28a7

refactor: remove jest setup

0ce054a

Ad96el marked this pull request as draft August 8, 2023 08:02

refactor: restructure

844cdbf

Ad96el marked this pull request as ready for review August 9, 2023 07:50

chore: copyright

b5042c7

weichweich reviewed Aug 9, 2023

View reviewed changes

rflechtner reviewed Aug 9, 2023

View reviewed changes

src/types/Message.ts Outdated Show resolved Hide resolved

src/messaging/CredentialApiMessageTypes.ts Outdated Show resolved Hide resolved

src/messaging/CredentialApiMessageTypes.ts Outdated Show resolved Hide resolved

Ad96el added 4 commits August 9, 2023 13:30

remove terms

f66bca6

remove newline

e026d9c

update imports

d4fb2a0

add comments

3f3aa01

weichweich reviewed Aug 9, 2023

View reviewed changes

src/tests/messageUtils.ts Outdated Show resolved Hide resolved

src/tests/messageUtils.ts Show resolved Hide resolved

src/tests/messageUtils.ts Show resolved Hide resolved

src/tests/messageUtils.ts Show resolved Hide resolved

src/types/Quote.ts Outdated Show resolved Hide resolved

Ad96el added 5 commits August 9, 2023 14:54

docs docs docs

92f433e

docs docs docs

e7dc7cc

feat: type guards

d1c69c7

feat: generics for message

a493e93

feat: type guards

13b7dcf

Ad96el added 2 commits August 10, 2023 16:09

refactor: errors

6bfd5d8

feat: default type

878fe28

weichweich reviewed Aug 11, 2023

View reviewed changes

arty-name reviewed Aug 14, 2023

View reviewed changes

weichweich suggested changes Aug 14, 2023

View reviewed changes

Ad96el added 2 commits August 14, 2023 12:46

newline

1aa812a

refactor: change return type

792dc5d

Ad96el force-pushed the refactor/messaging branch from 7ebb031 to 792dc5d Compare August 14, 2023 10:48

Ad96el added 2 commits August 14, 2023 12:51

fmt

1b23e4c

fix tests

b0bb518

rflechtner reviewed Aug 21, 2023

View reviewed changes

src/messaging/CredentialApiMessageType.ts Outdated Show resolved Hide resolved

Ad96el added 2 commits August 21, 2023 17:23

change response

c76cc9b

fix tests

dfaafcd

rflechtner reviewed Aug 22, 2023

View reviewed changes

src/messaging/utils.ts Outdated Show resolved Hide resolved

src/messaging/MessageEnvelope.ts Show resolved Hide resolved

src/messaging/index.ts Outdated Show resolved Hide resolved

src/index.ts Outdated Show resolved Hide resolved

Ad96el and others added 4 commits August 22, 2023 15:01

namespace

22073b2

Co-authored-by: Raphael Flechtner <[email protected]>

do not export verifyMessageEnvelope

e06c1ec

reduce interface

0a2ffb9

change body type

3969f72

rflechtner reviewed Aug 23, 2023

View reviewed changes

src/messaging/index.ts Outdated Show resolved Hide resolved

src/messaging/index.ts Outdated Show resolved Hide resolved

src/messaging/utils.ts Outdated Show resolved Hide resolved

src/messaging/utils.ts Outdated Show resolved Hide resolved

Ad96el added 3 commits August 23, 2023 16:23

remove comments

b5316c5

message body

64f5d52

from body generic

7d348a0

rflechtner reviewed Aug 24, 2023

View reviewed changes

src/messaging/utils.ts Show resolved Hide resolved

refactor types

a93d110

rflechtner approved these changes Sep 14, 2023

View reviewed changes

weichweich approved these changes Oct 5, 2023

View reviewed changes

Ad96el merged commit 3322558 into main Oct 5, 2023
1 check passed

Ad96el deleted the refactor/messaging branch October 5, 2023 07:27

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor: messaging #18

refactor: messaging #18

Ad96el commented Aug 4, 2023 •

edited

Loading

rflechtner left a comment

weichweich left a comment

weichweich left a comment

weichweich Aug 11, 2023

Ad96el Aug 11, 2023

arty-name Aug 14, 2023

Ad96el Aug 14, 2023

weichweich left a comment

Ad96el commented Aug 14, 2023

rflechtner left a comment

rflechtner left a comment

rflechtner left a comment

rflechtner commented Oct 2, 2023

weichweich left a comment

refactor: messaging #18

refactor: messaging #18

Conversation

Ad96el commented Aug 4, 2023 • edited Loading

fixes https://github.com/KILTprotocol/ticket/issues/2715

rflechtner left a comment

Choose a reason for hiding this comment

weichweich left a comment

Choose a reason for hiding this comment

weichweich left a comment

Choose a reason for hiding this comment

weichweich Aug 11, 2023

Choose a reason for hiding this comment

Ad96el Aug 11, 2023

Choose a reason for hiding this comment

arty-name Aug 14, 2023

Choose a reason for hiding this comment

Ad96el Aug 14, 2023

Choose a reason for hiding this comment

weichweich left a comment

Choose a reason for hiding this comment

Ad96el commented Aug 14, 2023

rflechtner left a comment

Choose a reason for hiding this comment

rflechtner left a comment

Choose a reason for hiding this comment

rflechtner left a comment

Choose a reason for hiding this comment

rflechtner commented Oct 2, 2023

weichweich left a comment

Choose a reason for hiding this comment

Ad96el commented Aug 4, 2023 •

edited

Loading