feat: unification of keypairs #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rflechtner
approved these changes
Aug 21, 2023
Comment on lines
43
to
45
| }, 20_000) | ||
|
|
||
| beforeAll(async () => { |
There was a problem hiding this comment.
the split in the two beforeAlls meant that we had 20 seconds allowed to starting the container, and then 30 seconds allotted to the setup. now we have 30 seconds for everything.
There was a problem hiding this comment.
Do you think I should revert this change?
There was a problem hiding this comment.
I think so, it had its reason
arty-name
reviewed
Sep 4, 2023
Co-authored-by: Tom Adler <[email protected]>
Dudleyneedham
force-pushed
the
dn-unification-keypair
branch
from
d8d6a54 to
9dcba1a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes https://github.com/KILTprotocol/ticket/issues/2889
Unification of keypairs
How to test:
Please provide a brief step-by-step instruction.
If necessary provide information about dependencies (specific configuration, branches, database dumps, etc.)
Checklist: