Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: interface #24

Merged
merged 103 commits into from
Nov 1, 2023
Merged

feat: interface #24

merged 103 commits into from
Nov 1, 2023

Conversation

Ad96el
Copy link
Member

@Ad96el Ad96el commented Aug 21, 2023

fixes KILTProtocol/ticket#2803

Open Todos:

  • write Documentation
  • write defaults for encrypt/decrpyt/sign callbacks

@Ad96el
Copy link
Member Author

Ad96el commented Oct 30, 2023

@rflechtner branch is merged with main

Copy link
Member

@Dudleyneedham Dudleyneedham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@rflechtner rflechtner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's changes on the package.json that seem like they shouldn't be there, as they mess with things we set up in the esm/cjs PR

package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
src/getExtension/index.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@rflechtner rflechtner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why am I seeing changes on the typescript config? Is that a merge conflict or something? Looks good to me otherwise!

src/types/Session.ts Show resolved Hide resolved
src/types/Session.ts Show resolved Hide resolved
tsconfig.build.json Outdated Show resolved Hide resolved
@Ad96el
Copy link
Member Author

Ad96el commented Nov 1, 2023

I have also verified that the interface is available at: @kiltprotocol/kilt-extension-api/messaging/interface.

jest.config.cjs Outdated
// Parachain block time is 12s
testTimeout: 12000,
collectCoverageFrom: ['**/*/src/**/*.ts'],
rootDir: 'src',
coverageDirectory: 'coverage',
moduleDirectories: [ 'dist', 'node_modules'],
moduleDirectories: ['dist', 'node_modules'],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think there is a dist directory now

Copy link
Collaborator

@rflechtner rflechtner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! replace the dist with whatever folder you meant (esm?) and then we're done here!

@Ad96el Ad96el merged commit 4c0c2f9 into main Nov 1, 2023
3 checks passed
@Ad96el Ad96el deleted the interface branch November 1, 2023 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants