-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: interface #24
feat: interface #24
Conversation
@rflechtner branch is merged with main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's changes on the package.json that seem like they shouldn't be there, as they mess with things we set up in the esm/cjs PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why am I seeing changes on the typescript config? Is that a merge conflict or something? Looks good to me otherwise!
I have also verified that the interface is available at: @kiltprotocol/kilt-extension-api/messaging/interface. |
jest.config.cjs
Outdated
// Parachain block time is 12s | ||
testTimeout: 12000, | ||
collectCoverageFrom: ['**/*/src/**/*.ts'], | ||
rootDir: 'src', | ||
coverageDirectory: 'coverage', | ||
moduleDirectories: [ 'dist', 'node_modules'], | ||
moduleDirectories: ['dist', 'node_modules'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think there is a dist directory now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! replace the dist
with whatever folder you meant (esm?) and then we're done here!
fixes KILTProtocol/ticket#2803
Open Todos: