-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: caching #657
ci: caching #657
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to get a bit more context into the different pieces of this PR, especially regarding the new try-runtime
file.
c3d8985
to
65412aa
Compare
Tested self hosted github action yet It takes way longer than gitlab. Check here |
f62409d
to
01384f0
Compare
ca285d4
to
1dda3d1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor stuff left, then I'll give it one last review top to bottom, but it looks already quite good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice! This is my last review, and it contains very minor things. Once these comments are addressed, we can merge and start riping the fruit!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two more comments!
Hacky way to cleanup disk space yet it works Deployed at [this link ](https://kiltprotocol.github.io/kilt-node/did/index.html) (Custom link possible). --------- Co-authored-by: gera <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job! Let's merge and see how it behaves!
## fixes KILTprotocol/ticket#3345 Breaks up the on `gitlab-ci.yml` & adds one more stage release. - [x] Migrate few jobs from gitlab to Github - [x] Enable caching ## Metadata Diff to Develop Branch <details> <summary>Peregrine Diff</summary> ``` ``` </details> <details> <summary>Spiritnet Diff</summary> ``` ``` </details> ## Checklist: - [ ] I have verified that the code works - [ ] No panics! (checked arithmetic ops, no indexing `array[3]` use `get(3)`, ...) - [ ] I have verified that the code is easy to understand - [ ] If not, I have left a well-balanced amount of inline comments - [ ] I have [left the code in a better state](https://deviq.com/principles/boy-scout-rule) - [ ] I have documented the changes (where applicable) * Either PR or Ticket to update [the Docs](https://github.com/KILTprotocol/docs) * Link the PR/Ticket here --------- Co-authored-by: Chris Chinchilla <[email protected]>
fixes KILTProtocol/ticket#3345
Breaks up the on
gitlab-ci.yml
& adds one more stage release.Metadata Diff to Develop Branch
Peregrine Diff
Spiritnet Diff
Checklist:
array[3]
useget(3)
, ...)