Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: caching #657

Merged
merged 55 commits into from
Aug 13, 2024
Merged

ci: caching #657

merged 55 commits into from
Aug 13, 2024

Conversation

ggera
Copy link
Member

@ggera ggera commented Jun 14, 2024

fixes KILTProtocol/ticket#3345

Breaks up the on gitlab-ci.yml & adds one more stage release.

  • Migrate few jobs from gitlab to Github
  • Enable caching

Metadata Diff to Develop Branch

Peregrine Diff
Spiritnet Diff

Checklist:

  • I have verified that the code works
    • No panics! (checked arithmetic ops, no indexing array[3] use get(3), ...)
  • I have verified that the code is easy to understand
    • If not, I have left a well-balanced amount of inline comments
  • I have left the code in a better state
  • I have documented the changes (where applicable)
    • Either PR or Ticket to update the Docs
    • Link the PR/Ticket here

@ggera ggera changed the title Ci cache ci: caching Jun 14, 2024
@ggera ggera requested review from Ad96el and ntn-x2 June 14, 2024 15:00
Copy link
Member

@ntn-x2 ntn-x2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to get a bit more context into the different pieces of this PR, especially regarding the new try-runtime file.

.gitlab-ci.yml Outdated Show resolved Hide resolved
.gitlab-ci.yml Outdated Show resolved Hide resolved
.gitlab/check.yml Show resolved Hide resolved
.github/workflows/try-runtime.yml Outdated Show resolved Hide resolved
.github/workflows/try-runtime.yml Outdated Show resolved Hide resolved
.github/workflows/try-runtime.yml Outdated Show resolved Hide resolved
.github/workflows/try-runtime.yml Outdated Show resolved Hide resolved
.github/workflows/try-runtime.yml Outdated Show resolved Hide resolved
.github/workflows/try-runtime.yml Outdated Show resolved Hide resolved
@ggera ggera force-pushed the ci-cache branch 5 times, most recently from c3d8985 to 65412aa Compare June 24, 2024 14:55
@ggera
Copy link
Member Author

ggera commented Jun 24, 2024

I'd like to get a bit more context into the different pieces of this PR, especially regarding the new try-runtime file.

I'd like to get a bit more context into the different pieces of this PR, especially regarding the new try-runtime file.

Tested self hosted github action yet It takes way longer than gitlab. Check here

@ggera ggera force-pushed the ci-cache branch 8 times, most recently from f62409d to 01384f0 Compare June 27, 2024 13:42
@ggera ggera force-pushed the ci-cache branch 2 times, most recently from ca285d4 to 1dda3d1 Compare June 27, 2024 14:25
Copy link
Member

@ntn-x2 ntn-x2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor stuff left, then I'll give it one last review top to bottom, but it looks already quite good.

.github/workflows/integration-tests.yml Outdated Show resolved Hide resolved
.github/workflows/try-runtime.yml Outdated Show resolved Hide resolved
.gitlab/check.yml Show resolved Hide resolved
@ggera ggera requested review from ntn-x2 and Ad96el and removed request for ntn-x2 August 9, 2024 11:16
Copy link
Member

@ntn-x2 ntn-x2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! This is my last review, and it contains very minor things. Once these comments are addressed, we can merge and start riping the fruit!

.github/workflows/integration-tests.yml Outdated Show resolved Hide resolved
.github/workflows/semantic-pr-title.yml Outdated Show resolved Hide resolved
.gitlab/check.yml Outdated Show resolved Hide resolved
.gitlab/check.yml Show resolved Hide resolved
.gitlab/build_docker_img.yml Outdated Show resolved Hide resolved
.github/workflows/integration-tests.yml Show resolved Hide resolved
.github/workflows/srtool-build.yml Outdated Show resolved Hide resolved
.github/workflows/srtool-build.yml Outdated Show resolved Hide resolved
.gitlab/build_docker_img.yml Outdated Show resolved Hide resolved
.github/workflows/srtool-build.yml Outdated Show resolved Hide resolved
@ggera ggera requested a review from ntn-x2 August 12, 2024 14:53
Copy link
Member

@ntn-x2 ntn-x2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two more comments!

.github/workflows/srtool-build.yml Outdated Show resolved Hide resolved
.github/workflows/srtool-build.yml Outdated Show resolved Hide resolved
ChrisChinchilla and others added 2 commits August 13, 2024 10:18
Hacky way to cleanup disk space yet it works
Deployed at [this link
](https://kiltprotocol.github.io/kilt-node/did/index.html) (Custom link
possible).

---------

Co-authored-by: gera <[email protected]>
Copy link
Member

@ntn-x2 ntn-x2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! Let's merge and see how it behaves!

@ggera ggera merged commit a4561c5 into develop Aug 13, 2024
6 of 9 checks passed
@ggera ggera deleted the ci-cache branch August 13, 2024 12:12
Ad96el pushed a commit that referenced this pull request Aug 20, 2024
## fixes KILTprotocol/ticket#3345
Breaks up the on `gitlab-ci.yml` & adds one more stage release.
- [x] Migrate few jobs from gitlab to Github
- [x]  Enable caching
## Metadata Diff to Develop Branch

<details>
<summary>Peregrine Diff</summary>

```
```

</details>

<details>
<summary>Spiritnet Diff</summary>

```
```

</details>

## Checklist:

- [ ] I have verified that the code works
- [ ] No panics! (checked arithmetic ops, no indexing `array[3]` use
`get(3)`, ...)
- [ ] I have verified that the code is easy to understand
  - [ ] If not, I have left a well-balanced amount of inline comments
- [ ] I have [left the code in a better
state](https://deviq.com/principles/boy-scout-rule)
- [ ] I have documented the changes (where applicable)
* Either PR or Ticket to update [the
Docs](https://github.com/KILTprotocol/docs)
    * Link the PR/Ticket here

---------

Co-authored-by: Chris Chinchilla <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants