Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integer and string support for NdArray values (second attempt) #20

Merged
merged 23 commits into from
Nov 22, 2024

Conversation

PaulVanSchayck
Copy link
Collaborator

Second attempt (first attempt)

Adds support for integer and string data types in NdArray values, aligning with the OGC CoverageJSON spec.

Added relevant tests for integer and string case.

Copy link

codecov bot commented Nov 14, 2024

Codecov Report

Attention: Patch coverage is 96.55172% with 1 line in your changes missing coverage. Please review.

Project coverage is 94.01%. Comparing base (5809d8c) to head (831727c).
Report is 24 commits behind head on master.

Files with missing lines Patch % Lines
src/covjson_pydantic/coverage.py 90.90% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #20      +/-   ##
==========================================
+ Coverage   93.97%   94.01%   +0.04%     
==========================================
  Files           9        9              
  Lines         282      301      +19     
==========================================
+ Hits          265      283      +18     
- Misses         17       18       +1     
Flag Coverage Δ
unittests 94.01% <96.55%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@PaulVanSchayck PaulVanSchayck merged commit d1bc2c8 into master Nov 22, 2024
8 checks passed
@PaulVanSchayck PaulVanSchayck deleted the ndarray-str branch November 22, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants