feature(icon-export): add batching and multi page processing #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for pine-icons ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
scripts/helpers.ts
Outdated
| @@ -89,7 +89,6 @@ export const reservedKeywords = new Set([ | |||
| 'throw', | |||
| 'while', | |||
| 'yield', | |||
| 'delete', | |||
There was a problem hiding this comment.
Was removing this intentional?
There was a problem hiding this comment.
ugh...No, but Design does have an icon named delete. We will need them to address the conflict. Great catch 🦅 👁️ 😂
request in batches
ju-Skinner
force-pushed
the
feature/add-batching-and-multi-page-processing
branch
from
ae1fe2a to
9023f1f
Compare
ju-Skinner
deleted the
feature/add-batching-and-multi-page-processing
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As design looks to increase the number of icons in the library, the tool needed to be refactored to handle accordingly.
Solution