Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix failing specs due to missing CSS Custom Prop #25

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

ju-Skinner
Copy link
Collaborator

Description

Icon specs were failing due to missing CSS Custom Property

Fixes #(issue)

Type of change

  • Test

How Has This Been Tested?

  • unit tests

Checklist:

If not applicable, leave options unchecked.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes
  • Design has QA'ed and approved this PR

@ju-Skinner ju-Skinner self-assigned this Aug 28, 2024
@ju-Skinner ju-Skinner requested a review from a team August 28, 2024 18:28
Copy link
Member

@pixelflips pixelflips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pixelflips pixelflips requested a review from a team August 28, 2024 18:29
Copy link

netlify bot commented Aug 28, 2024

Deploy Preview for pine-icons ready!

Name Link
🔨 Latest commit 988094a
🔍 Latest deploy log https://app.netlify.com/sites/pine-icons/deploys/66cf6c51fe48d60008fe8241
😎 Deploy Preview https://deploy-preview-25--pine-icons.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ju-Skinner ju-Skinner merged commit 61333cb into main Aug 28, 2024
15 of 16 checks passed
@ju-Skinner ju-Skinner deleted the test/fix-failing-specs branch August 28, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants