Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect unary precedence #297

Merged
merged 10 commits into from
Jun 9, 2024
Merged

Fix incorrect unary precedence #297

merged 10 commits into from
Jun 9, 2024

Conversation

chriscerie
Copy link
Contributor

Fixes #296.

chriscerie
chriscerie commented Apr 7, 2024
View reviewed changes
full-moon/src/ast/mod.rs Outdated Show resolved Hide resolved
@chriscerie chriscerie marked this pull request as ready for review April 7, 2024 19:43
JohnnyMorganz
JohnnyMorganz approved these changes Apr 9, 2024
View reviewed changes
Copy link
Collaborator

@JohnnyMorganz JohnnyMorganz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (I did not look at the snapshots in detail as GitHub doesn't display it in a useful way, will try to look in better detail in code editor later)

Can you also add the test cases that I initially sent on Discord?

full-moon/src/ast/parsers.rs Outdated Show resolved Hide resolved
@chriscerie chriscerie mentioned this pull request Jun 8, 2024
Merged
@JohnnyMorganz JohnnyMorganz merged commit fa651f7 into Kampfkarren:main Jun 9, 2024
2 checks passed
@chriscerie chriscerie deleted the fix-unary branch June 9, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnnyMorganz JohnnyMorganz JohnnyMorganz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect unary precedence
2 participants
@chriscerie @JohnnyMorganz