Add authentication support for Companion cameras #527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Companion cameras require the `Axis-Orig-Sw=true` query string parameter in the rtsp url. Otherwise they respond with a 403. I do not have the possibility with another camera model, so it's unclear if this affects other cameras. In that case AxisDevice might need some parameter to control this or the info could be derived from Vapix.
|
Hello. This is not a good solution. It should be explicit if its a companion camera or ordinary camera. Some sort of instructions to different paths is needed from a central point |
|
Hi!
Could we do it when creating an AxisDevice, e.g. isCompanion=True ?
/ Lars
… On 13 Nov 2024, at 18:42, Robert Svensson ***@***.***> wrote:
Hello. This is not a good solution. It should be explicit if its a companion camera or ordinary camera. Some sort of instructions to different paths is needed from a central point
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
|
Adding it to the config object would be the correct path. And it should default to false |
|
Updated config. |
|
Hello! I should be able to start review this on wednesday |
|
Your fixing this only for RTSP, can you fix it for vapix as well? |
|
I can fix this, given I find some time these days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Companion cameras require the
Axis-Orig-Sw=truequery string parameter in the rtsp url. Otherwise they respond with a 403.I do not have the possibility with another camera model, so it's unclear if this affects other cameras. In that case AxisDevice might need some parameter to control this or the info could be derived from Vapix.