Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use generic checks for missing columns🙂 #71

Merged
merged 2 commits into from
Jan 13, 2024

Conversation

KarelZe
Copy link
Owner

@KarelZe KarelZe commented Jan 11, 2024

closes #68

@KarelZe KarelZe added the python Pull requests that update Python code label Jan 11, 2024
@KarelZe KarelZe self-assigned this Jan 11, 2024
Copy link

codecov bot commented Jan 11, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (0b96efe) 100.00% compared to head (8be823c) 99.24%.
Report is 2 commits behind head on main.

Files Patch % Lines
src/tclf/classical_classifier.py 92.30% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##              main      #71      +/-   ##
===========================================
- Coverage   100.00%   99.24%   -0.76%     
===========================================
  Files            4        4              
  Lines          259      266       +7     
  Branches        27       28       +1     
===========================================
+ Hits           259      264       +5     
- Partials         0        2       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@KarelZe KarelZe merged commit 06b1e4a into main Jan 13, 2024
12 of 14 checks passed
@KarelZe KarelZe deleted the presence-of-columns branch January 13, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python Pull requests that update Python code
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

Use generic checks to test for presence of required columns
1 participant