Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

03a-data-binding #9

Open
wants to merge 1 commit into
base: 02b-room-migrations
Choose a base branch
from
Open

03a-data-binding #9

wants to merge 1 commit into from

Conversation

Serchinastico
Copy link
Contributor

This PR is not meant to be merged

This is how to add the Data Binding component to the project:

  • Configure data-binding component. This has forced us to enable Jetifier and AndroidX to be fully compatible with other libraries not using appcompat libs.
  • Change the way we are inflating activity layouts to use the DataBindingUtils method instead. We hold a reference to the binding field to update its variables once we load the information we are about to present.
  • Apply data binding tags to all 3 screen layouts. Most of them have a variable with the information we have to display and a listener to send events to presenters.

@Serchinastico Serchinastico force-pushed the 02b-room-migrations branch 2 times, most recently from 0aabfb0 to a4d4f7d Compare January 30, 2019 16:11
@davideme
Copy link
Member

👍

@Serchinastico Serchinastico force-pushed the 02b-room-migrations branch 2 times, most recently from be53161 to 1f60144 Compare March 15, 2019 16:50
@Serchinastico Serchinastico force-pushed the 02b-room-migrations branch from daebed5 to ce35d84 Compare May 21, 2019 10:23
@Serchinastico Serchinastico force-pushed the 02b-room-migrations branch 2 times, most recently from 7093a05 to 92b4d48 Compare May 21, 2019 14:50
@Serchinastico Serchinastico force-pushed the 02b-room-migrations branch from 92b4d48 to 3e9ac7d Compare May 22, 2019 16:36
@Serchinastico
Use layout tag in all layout xml files. Use androidx to fix compilati…
6724b54 
…on issues

Configure listener with data binding

Map all super hero detail fields into the layout

Use data binding in the edit super heroes screen

Migrate to pure data binding super hero detail

Finish migrating to data binding

Fix all tests

Add comment explaining why are we using our own InstrumentationRegistry class

Remove useless call
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davideme davideme davideme left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Serchinastico @davideme