Update gradle #97
Update gradle #97
Conversation
Also, add a common configuration with variables in the Rosie gradle file to easily change this configurations in the library and the samples at the same time.
Also, added google() repository to gradle because now it's mandatory.
|
|
||
| provided 'com.squareup.dagger:dagger-compiler:1.2.2' | ||
| annotationProcessor 'com.squareup.dagger:dagger-compiler:1.2.2' | ||
| compileOnly 'com.squareup.dagger:dagger-compiler:1.2.2' |
There was a problem hiding this comment.
I don't know why the dagger dependency is added twice but I maintain them.
|
|
||
| provided 'com.squareup.dagger:dagger-compiler:1.2.2' | ||
| annotationProcessor 'com.squareup.dagger:dagger-compiler:1.2.2' | ||
| compileOnly 'com.squareup.dagger:dagger-compiler:1.2.2' |
|
Should be updated: I have to add a modification to make the CI accept the new Terms And Conditions when updating it. Let me ask a friend of mine about it |
|
You are absolutely right @Aracem the wrapper is updated. I didn't see the file, my bad. We will wait until the build passes to merge this branch. Thank you so much 😃 |
|
The builds are broken due the com.android.library plugin, that download dependencies but Google adds a "accepts terms and conditions" question while downloading, so you have to configure CI to accept it. Here is the solution: https://stackoverflow.com/a/45782695/628447 |
Aracem
force-pushed
the
update-gradle
branch
4 times, most recently
from
9f62aab to
67ba6f4
Compare
Please, review this tutorial for a better understanding of this commit: https://developer.android.com/studio/build/gradle-plugin-3-0-0-migration Apply this new rules to the gradle files, changing compile by implementation and adding annotationProcessor. Also, edit the order of the repositories jcenter() and google() to avoid download dependencies errors.
🎩 What is the goal?
Update Gradle (tools, wrapper..) to improve the compilation time and take advantage of the last improvements in Android Studio 3.0.
Also, update dependencies to follow new implementation/api instead of compile standard, that helps to improve compilation times
How is it being implemented?
https://developer.android.com/studio/build/gradle-plugin-3-0-0-migration?utm_source=android-studio#new_configurations
GIF