Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes 37235 - Add verify-checksum command for CV versions in hammer #932

Merged
merged 1 commit into from
Mar 8, 2024

Conversation

sjha4
Copy link
Member

@sjha4 sjha4 commented Mar 8, 2024

What are the changes introduced in this pull request?

  1. Add a hammer action for verify-checksum on CV versions

What are the testing steps for this pull request?

Run the command below with Katello/katello#10923 checked out.
hammer -r content-view version verify-checksum --id :id --organization "Default_Organization"

@sjha4 sjha4 force-pushed the add_version_verify_checksum branch from 09d941a to 6e396b2 Compare March 8, 2024 16:01
@chris1984 chris1984 self-assigned this Mar 8, 2024
Copy link
Member

@chris1984 chris1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, code looks fine and works well:

[vagrant@hammer ~]$ hammer -r content-view version verify-checksum --id 3 --organization "Default_Organization"
[...............................................................................................................] [100%]

I would say we add a test but since we are just making an API call to generate a task, i'm fine with skipping it.

@sjha4
Copy link
Member Author

sjha4 commented Mar 8, 2024

Will merge after the katello PR is merged. Thanks @chris1984 !

@sjha4 sjha4 merged commit a6bbddd into Katello:master Mar 8, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants