Fixes #36722 - restore Katello::Ping.packages #10720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was wrongly removed during katello-agent removal. Instead of removing this, update the package list to not list qpid. Fixes: ea06f3d
|
Issues: #36722 |
jeremylenz
approved these changes
Sep 6, 2023
|
I suspect this also broke 4.10.0-rc1: https://community.theforeman.org/t/katello-4-10-rpm-pipeline-3-failed/35046 |
lfu
pushed a commit
that referenced
this pull request
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes introduced in this pull request?
Brings back
Katello::Ping.packageswhich was wrongly removed during katello-agent removal.Instead of removing this, update the package list to not list qpid.
Considerations taken when implementing this change?
The data provided is still valuable, so instead of removing it, make it work again.
What are the testing steps for this pull request?
Go to
/abouton your Katello installation.Without the patch, you get a 502, with the patch it works ;-)