Fixes #36492 - duplicate content warning for composite CVs for non-docker repos #10741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issues: #36492 |
|
Test failures expected. Will update those. |
sjha4
force-pushed
the
dup_rep_warning_composite_cv
branch
from
4aee0d4 to
7644c2a
Compare
|
Updated tests..Should be green.. |
jeremylenz
requested changes
Sep 26, 2023
sjha4
force-pushed
the
dup_rep_warning_composite_cv
branch
from
7644c2a to
d1b45c6
Compare
sjha4
force-pushed
the
dup_rep_warning_composite_cv
branch
from
d1b45c6 to
7bb76f2
Compare
sjha4
force-pushed
the
dup_rep_warning_composite_cv
branch
from
7bb76f2 to
d689532
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes introduced in this pull request?
Adds a notice to composite CVs publish screen if component CV versions have the same repositories added.
Considerations taken when implementing this change?
What are the testing steps for this pull request?
1, Create 2 CV versions with same repo
2.Add both to a composite CV
3. Publish. You should see a notice explaining duplicate content will be merged into the Composite CV version. The text is copied from earlier: https://github.com/Katello/katello/pull/8198/files