-
Notifications
You must be signed in to change notification settings - Fork 296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #36756 - Add a banner warning about RHEL lifecycle EOS per content host #10747
Conversation
Issues: #36756 |
045f42c
to
b02739c
Compare
@@ -30,6 +30,10 @@ angular.module('Bastion.hosts').factory('Host', | |||
return _.isString(this.operatingsystem_name) && (this.operatingsystem_name.indexOf("Debian") >= 0 || this.operatingsystem_name.indexOf("Ubuntu") >= 0); | |||
}; | |||
|
|||
resource.prototype.rhelLifecycleExpireSoon = function() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you like this format better or the React way of doing things?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
React is easier to understand to me.
b02739c
to
046e287
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the latest changes, nice work Lucy 😄 Will test it with a few RHEL hosts Monday. Code wise it looks great
What are the changes introduced in this pull request?
Considerations taken when implementing this change?
What are the testing steps for this pull request?
A banner is displayed warning about RHEL lifecycle EOS per content host