Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #36756 - Add a banner warning about RHEL lifecycle EOS per content host #10747

Merged
merged 1 commit into from
Oct 2, 2023

Conversation

lfu
Copy link
Member

@lfu lfu commented Sep 19, 2023

What are the changes introduced in this pull request?

Considerations taken when implementing this change?

What are the testing steps for this pull request?

A banner is displayed warning about RHEL lifecycle EOS per content host

@theforeman-bot
Copy link

Issues: #36756

@lfu
Copy link
Member Author

lfu commented Sep 20, 2023

Screenshot at 2023-09-20 16-28-33

@@ -30,6 +30,10 @@ angular.module('Bastion.hosts').factory('Host',
return _.isString(this.operatingsystem_name) && (this.operatingsystem_name.indexOf("Debian") >= 0 || this.operatingsystem_name.indexOf("Ubuntu") >= 0);
};

resource.prototype.rhelLifecycleExpireSoon = function() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you like this format better or the React way of doing things?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

React is easier to understand to me.

Copy link
Member

@chris1984 chris1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the latest changes, nice work Lucy 😄 Will test it with a few RHEL hosts Monday. Code wise it looks great

@chris1984
Copy link
Member

ACK works well, tested with RHEL 6/7/8

Screenshot 2023-10-02 at 14-49-17 Content Host rhel6 area51 example com
Screenshot 2023-10-02 at 14-23-48 Content Host rhel8 area51 example com
Screenshot 2023-10-02 at 14-21-21 Content Host rhel7 area51 example com

@lfu lfu merged commit bd25373 into Katello:master Oct 2, 2023
5 checks passed
@lfu lfu deleted the content_host_eos_36756 branch November 16, 2023 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants