Fixes #36766 - Set disks to amount of disks instead of bytes

[chris1984]

What are the changes introduced in this pull request?

• We had the number of disks using bytes instead of an actual count
• I fixed the count by looking at the block devices and filtering out the cdrom or sr0

Considerations taken when implementing this change?

• https://projects.theforeman.org/issues/36344 is assigned to someone from the Foreman team who will add the facts from Puppet.
• Since we are fixing the total disks, I kept this pr doing the same thing instead of taking over the 36344 card.

What are the testing steps for this pull request?

• Apply PR
• Register a client
• Check to see if it reports the correct disk counts

Before PR: https://community.theforeman.org/t/hosts-ram-details-buggy/35050/7?u=cintrix84

After PR:

[chris1984]

@sbernhard How does this look? I took a different approach since there is another redmine that someone else is working on for adding puppet support. I just altered the disks to be the correct total like we had before but with a different method of getting the disks.

The girl working on the puppet support will update this card in the future

[sbernhard]

Maybe a more generic question: is the amount of disks a system has really interesting? Or should it just list the size of the storage?

[chris1984]

Maybe a more generic question: is the amount of disks a system has really interesting? Or should it just list the size of the storage?

I think having both would be beneficial, I will do the total disks and the other Redmine is being looked at for adding disk info from puppet_facts.

[sbernhard]

What's the reason to close this PR @chris1984 ?
I think we should still try to fix this isuse.

[ekohl]

Thinking more about it: it would probably still be a valid bug fix cherry pick.

[sbernhard]

Are the failed tests related to this change? Would be good to finish this soonish.

[chris1984]

It looks like they just didn't run. Let me rekick it. @ekohl do you think this is fine as it is or want me to apply more filtering logic to this commit as suggested in the comment I made?

[chris1984]

@sbernhard tests are green if you want to test it

[sbernhard]

@sbernhard tests are green if you want to test it

I tested it together with my suggestion and it worked:

[sbernhard]

Thanks. Works as expected.

[chris1984]

Awesome, thanks for testing it. Will get you change in and pushed up so we can get it in.

[chris1984]

@sbernhard pushed up your fix, will put this on the review board for someone with merge access to ack it so it can be merged

[chris1984]

[test katello]

[chris1984]

@jeremylenz how does this look?

[jeremylenz]

LGTM! 👍