Fixes #36820 - translate modulemd content counts

[ianballou]

What are the changes introduced in this pull request?

Module streams weren't translated properly to Katello terms for smart proxy counts.

Considerations taken when implementing this change?

I considered that rpm.modulemd is completely confusing for Katello users.

What are the testing steps for this pull request?

1. Sync a smart proxy with some module streams
2. curl -X GET https://hostname/katello/api/capsules/2/content/counts -H "Content-Type: application/json" -uadmin:changeme | jq
3. See that instead of rpm.modulemd it says "module_stream" for module streams.

[theforeman-bot]

Issues: #36820

[chris1984]

Looks good, here is my output:

vagrant@centos8-katello-devel ~]$ curl -X GET https://centos8-katello-devel.area51.example.com/katello/api/capsules/2/content/counts -H "Content-Type: application/json" -uadmin:changeme | jq
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   967  100   967    0     0   4883      0 --:--:-- --:--:-- --:--:--  4859
{
  "content_view_versions": {
    "2": {
      "repositories": {
        "24": {
          "file": 3
        },
        "25": {
          "ansible.collection_version": 14
        },
        "26": {
          "rpm": 35,
          "erratum": 4,
          "package_group": 2,
          "rpm.packagecategory": 1,
          "rpm.packagelangpacks": 1
        },
        "27": {
          "ostree_ref": 2,
          "ostree.commit": 2,
          "ostree.config": 1,
          "ostree.object": 3,
          "ostree.summary": 1
        },
        "28": {
          "python_package": 2
        },
        "29": {
          "rpm": 22,
          "erratum": 7,
          "module_stream": 14,
          "package_group": 2,
          "rpm.packagecategory": 1,
          "rpm.distribution_tree": 1,
          "rpm.modulemd_defaults": 3
        },
        "30": {
          "docker_tag": 3,
          "container.blob": 27,
          "docker_manifest": 9,
          "docker_manifest_list": 3
        }
      },
      "cv_version_content_counts": {
        "rpm": 57,
        "file": 3,
        "erratum": 11,
        "docker_tag": 3,
        "ostree_ref": 2,
        "module_stream": 14,
        "ostree.commit": 2,
        "ostree.config": 1,
        "ostree.object": 3,
        "package_group": 4,
        "container.blob": 27,
        "ostree.summary": 1,
        "python_package": 2,
        "docker_manifest": 9,
        "rpm.packagecategory": 2,
        "docker_manifest_list": 3,
        "rpm.packagelangpacks": 1,
        "rpm.distribution_tree": 1,
        "rpm.modulemd_defaults": 3,
        "ansible.collection_version": 14
      }
    }

One question I have is do we want to change this field too? rpm.modulemd_defaults Looks like a few failing tests too :(

[ianballou]

One question I have is do we want to change this field too? rpm.modulemd_defaults Looks like a few failing tests too :(

We don't index modulemd_defaults along with some other types, like container.blob. I'm just translating the ones that users would understand. I'll take a look at the failing tests.

[ianballou]

I really wish we didn't make the content type for module streams be "modulemd" internally, but I think it'll have to stay for now... we use it all over the place. So, to get around it, I'm just going to hardcode the translation for modulemds to be "module_stream".

[chris1984]

ACK, looks good

[ianballou]

[test katello]