Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #36862 - Added the slot fill for hosts index #10771

Merged
merged 1 commit into from
Oct 28, 2023
Merged

Fixes #36862 - Added the slot fill for hosts index #10771

merged 1 commit into from
Oct 28, 2023

Conversation

parthaa
Copy link
Contributor

@parthaa parthaa commented Oct 18, 2023

What are the changes introduced in this pull request?

This adds the Change Content Source action to the HostsIndex page

Goes with PR => theforeman/foreman#9860

What are the testing steps for this pull request?

Check out both theforeman/foreman#9860 and this PR

  • Goto Administer > Settings and set the new_hosts_pages property to true
  • Reload the page
  • Go to Hosts > All Hosts => you should see the new page
  • Click on the kebab
  • You should notice the Change Content Source action (disabled if nothing is selected, enable if something is.)
  • Select a few hosts and click on the kebab.
  • Make sure the change content source actually redirects you to the correct page.

@parthaa parthaa mentioned this pull request Oct 18, 2023
Merged
@jeremylenz
Copy link
Member

[test katello]

@jeremylenz
Copy link
Member

Need a Katello redmine, it won't be happy otherwise :(

@parthaa parthaa force-pushed the HostsIndex branch 7 times, most recently from bfb904e to 81b2975 Compare October 25, 2023 03:36
@jeremylenz
Copy link
Member

@parthaa Need to make a Katello Redmine issue for this and adjust the commit message

jeremylenz
jeremylenz approved these changes Oct 25, 2023
View reviewed changes
Copy link
Member

@jeremylenz jeremylenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APJ

@parthaa parthaa changed the title Refs #36822 - Added the slot fill for hosts index Fixes #36862 - Added the slot fill for hosts index Oct 25, 2023
@jeremylenz
Copy link
Member

[test katello]

@parthaa @jeremylenz
fixes #36862 - Added the slot fill for hosts index
6f00ae5 
Update webpack/components/extensions/Hosts/ActionsBar/index.js

Co-authored-by: Jeremy Lenz <[email protected]>
@jeremylenz
Copy link
Member

[test katello]

1 similar comment
@parthaa
Copy link
Contributor Author

parthaa commented Oct 26, 2023

[test katello]

@jeremylenz
Copy link
Member

[test rpm-build:centos-stream-8-x86_64]

@jeremylenz
Copy link
Member

[test rpm-build]

@jeremylenz
Copy link
Member

rpm-build test failure is unrelated

Module build failed: ModuleBuildError: Module build failed: Error: Missing binding /usr/lib/node_modules/node-sass/vendor/linux-x64-72/binding.node
Node Sass could not find a binding for your current environment: Linux 64-bit with Node.js 12.x

you can go ahead and merge @parthaa

@parthaa parthaa merged commit c90b9a0 into Katello:master Oct 28, 2023
4 of 5 checks passed
@parthaa parthaa deleted the HostsIndex branch October 28, 2023 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremylenz jeremylenz jeremylenz approved these changes

Assignees
No one assigned
Labels
Needs re-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@parthaa @jeremylenz