Fixes #36853 - Fix the tests that caused SIGKILL #10774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremylenz
approved these changes
Oct 23, 2023
|
let's run them a few times before we merge to make sure it stays green |
|
[test katello] |
|
🍏 [test katello] |
|
[test katello] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes introduced in this pull request?
Seems line like
Time.stubs(:now).returns(Time.utc(2024, 1, 1))alone without other code would cause SIGKIL.Considerations taken when implementing this change?
What are the testing steps for this pull request?
bundle exec rake jenkins:katello TESTOPTS="-v" --tracecould pass without SIGKIL.