Fixes #36859 - Fix inconsistent repo publication

[m-bucher]

Fix repo not having correct publication due to e.g. killed pulp-publication task.
Or rather make sure next Optimized Sync will fix this, by identifying the inconsistency.

[quba42]

Or rather make sure next Optimized Sync will fix this, by identifying the inconsistency.

This is not actually related to optimized vs. complete sync. Both types won't repair an affected repo without this change, unless there is new content in the upstream repo being synced. If there is no new content in the upstream, both types of sync will not create a new pulp repo version (full sync will simply take longer to not create a new repo version). And in both cases Katello will not republish if there is no new repo version.

Only a "republish repository metadata" action can force a republish, which can currently only be achieved via hammer.

[m-bucher]

Is this the correct file for the test?

I kinda doubt it, but it seemed to be the best fir without creating a new test-class 😇

[ianballou]

Works for me!

[sbernhard]

Can you please have a look at this @jeremylenz ? Any thoughts as we think, this should fix a pretty bad bug.

[jeremylenz]

Added a review card to our sprint, thanks!

[quba42]

For the benefit of any potential reviewers: Note that I put fairly detailed reproducer instructions on the accompanying issue: https://projects.theforeman.org/issues/36859

[ianballou]

Thanks for the contribution! Just one bug found:

[m-bucher]

[test katello]

[ianballou]

Working for me! I tested it by editing the publication_href for a repository to a new one that I created. After syncing, the repository's publication_href was returned to normal.