Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #37044 - Remove LCE option from registration API #10844

Merged
merged 1 commit into from
Jan 15, 2024

Conversation

chris1984
Copy link
Member

What are the changes introduced in this pull request?

Considerations taken when implementing this change?

  • N/A

What are the testing steps for this pull request?

  • Checkout PR
  • Fetch the new API doc with hammer by doing hammer -r
  • Run hammer host-registration generate-command --help | grep lifecycle see if the option is removed

Copy link
Member

@jeremylenz jeremylenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[vagrant@centos8-katello-devel-stable hammer-cli-katello]$ hammer host-registration generate-command --help | grep lifecycle
[vagrant@centos8-katello-devel-stable hammer-cli-katello]$ 

Works as advertised
ACK 👍

@stejskalleos
Copy link
Contributor

Can we merge the PR so it will get to the upcoming snap and the next Sat release?

@chris1984 chris1984 merged commit 5992bdd into Katello:master Jan 15, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants