Refs #36846 - change descriptionFormat to snake case #10846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremylenz
force-pushed
the
36846-stupid-stupid-snake-case
branch
from
ef24356 to
1657164
Compare
|
[test katello] |
|
|
ianballou
approved these changes
Jan 17, 2024
ianballou
pushed a commit
to ianballou/katello
that referenced
this pull request
Feb 16, 2024
(cherry picked from commit dfe70e8)
ianballou
pushed a commit
that referenced
this pull request
Feb 27, 2024
(cherry picked from commit dfe70e8)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes introduced in this pull request?
In #10772 a new feature was introduced, but the
descriptionFormatrequest parameter was never translated to snake case, so it wasn't getting sent in the API request.This appears to be the result of a commit made after the PR was acked, adding a test (and breaking the real-life behavior in the process:)
Considerations taken when implementing this change?
uggghhhghh
What are the testing steps for this pull request?
Install or remove a package and verify that the toast contains the package name(s) as in #10772 (you may have to also cherry-pick #10845)