Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #37206 - Allow hosts to not have an os #10908

Closed
wants to merge 1 commit into from

Conversation

adamruzicka
Copy link
Member

Fixes f14f58e

What are the changes introduced in this pull request?

Hosts are no longer required to have an OS assigned in order for host details to show for them.

Considerations taken when implementing this change?

While having an OS assigned makes sense from katello point of view, we didn't require it prior to f14f58e

What are the testing steps for this pull request?

  1. Have a host without an OS, see the hammer command below
  2. Go to /hosts/myhost.example.com
    hammer host create\
        --name "myhost.example.com" \
        --managed false \
        --build false \
        --organization "Default Organization" \
        --location "Default Location"

Without this page the backend returns 500 and frontend redirects to the not found page.

@ianballou
Copy link
Member

Closing since #10897 is merged and has the same exact changes.

@ianballou ianballou closed this Feb 28, 2024
@adamruzicka adamruzicka deleted the host-os branch February 29, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants