Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #38023 - Stop using deprecated methods for ActiveModel::Errors #11226

Merged
merged 1 commit into from
Nov 20, 2024
Merged

Fixes #38023 - Stop using deprecated methods for ActiveModel::Errors #11226

merged 1 commit into from
Nov 20, 2024

Conversation

ofedoren
Copy link
Contributor

What are the changes introduced in this pull request?

Deprecation fixes:

  • Changing #<< to #add for ActiveModel::Errors objects
  • Changing #keys to #attribute_names for ActiveModel::Errors objects

Considerations taken when implementing this change?

Extracted from #11155 for easier review/merge.

What are the testing steps for this pull request?

  • Hope tests are green
  • Hope I didn't overlook anything

@ekohl

ekohl
ekohl approved these changes Nov 20, 2024
View reviewed changes
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ekohl ekohl mentioned this pull request Nov 20, 2024
Merged
@ofedoren
Copy link
Contributor Author

ofedoren commented Nov 20, 2024 •
edited
Loading

Don't merge yet, seems failures are related.

@ofedoren ofedoren force-pushed the ref-38023-use-add-error branch from c496521 to 5774dcb Compare November 20, 2024 15:32
ianballou
ianballou approved these changes Nov 20, 2024
View reviewed changes
Copy link
Member

@ianballou ianballou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me!

@ianballou ianballou merged commit b09afe6 into Katello:master Nov 20, 2024
26 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ianballou ianballou ianballou approved these changes

@ekohl ekohl ekohl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ofedoren @ekohl @ianballou