Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #38026 - Remove redundant 'require' calls #11228

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

ofedoren
Copy link
Contributor

What are the changes introduced in this pull request?

This is extracted from #11155.

Considerations taken when implementing this change?

During Zeitwerk-related changes I've missed some calls that are no longer needed, which are also Rails 7 incompatible.

What are the testing steps for this pull request?

Mostly ensuring there are no errors during app loading and the tests are green meaning there are no "undefined constant" errors.

@ekohl

Copy link
Member

@ianballou ianballou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ianballou ianballou merged commit 39c5b58 into Katello:master Nov 20, 2024
26 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants