Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #38058 - Fix applied errata report #11245

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

adamruzicka
Copy link
Member

What are the changes introduced in this pull request?

The "Host - Applied Errata" report template got broken by recent CVE fixes in foreman introduced in theforeman/foreman#10367 . This fixes the template by taking a slightly different path to get the data we need, while avoiding the now constrained apis.

Considerations taken when implementing this change?

There are multiple ways how we could get the data we need, this is probably the shortest one.

What are the testing steps for this pull request?

  1. Apply errata to a host
  2. Try to render "Host - Applied Errata"

Copy link
Member

@sbernhard sbernhard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works. Thanks.

Copy link
Contributor

@ofedoren ofedoren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @adamruzicka, LGTM and fixes the issue

@sbernhard sbernhard merged commit 7655a15 into Katello:master Dec 4, 2024
26 checks passed
@adamruzicka adamruzicka deleted the applied-errata-report branch December 5, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants