Fixes #38083 - Add repository filter to Debian packages page #11255
+73
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nadjaheitmann
force-pushed
the
38083_packages_deb_repo_filter
branch
5 times, most recently
from
41c7cab to
1a1257a
Compare
ianballou
requested changes
Dec 11, 2024
There was a problem hiding this comment.
Missed the failing test, we can merge once it's fixed:
HeadlessChrome 131.0.0 (Linux 0.0.0) Controller: DebsController should set the repository_id param on Nutupane when a repository is chosen FAILED
Error: <spyOn> : could not find an object to spy upon for setParams()
Usage: spyOn(<object>, <methodName>)
at UserContext.<anonymous> (/home/runner/work/katello/katello/engines/bastion_katello/test/debs/debs.controller.test.js:69:9)
1a1257a to
a4fb7ac
Compare
|
Thanks @ianballou! Tests are green now 🟢 :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes introduced in this pull request?
Adding repository filter for Deb Packages page:
Considerations taken when implementing this change?
In Content --> Content Type --> Packages we have a repository filter. We want the same for Deb packages.
What are the testing steps for this pull request?