Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop geometry types support #244

Merged
merged 1 commit into from
Mar 9, 2016
Merged

Drop geometry types support #244

merged 1 commit into from
Mar 9, 2016

Conversation

foxycode
Copy link
Contributor

@foxycode foxycode commented Mar 8, 2016

Related to #238

@fprochazka
Copy link
Member

If anyone was using these, I encourage you to copy the code (or write better) and create your own package, because they will be removed in v4.0.
And if you're going to do that, I encourage you to make the package framework-independent.

fprochazka added a commit that referenced this pull request Mar 9, 2016
Drop geometry types support
@fprochazka fprochazka merged commit bae58f5 into Kdyby:master Mar 9, 2016
@fprochazka
Copy link
Member

@foxycode thank you

@fprochazka
Copy link
Member

FYI, this looks really good on first look: https://github.com/creof/doctrine2-spatial

@foxycode
Copy link
Contributor Author

foxycode commented Mar 9, 2016

@fprochazka What about that enum type? Shouldn't we drop it too? There sure are independent packages with doctrine types, I use oro/doctrine-extensions which doesn't have enum, but we can surely create independent type package too.

@foxycode foxycode deleted the drop-geo branch March 9, 2016 15:06
@fprochazka
Copy link
Member

@foxycode agreed, but I don't like the current implementation. Also, using enums with mysql is pure shit, and using one enum with postgres doesn't make sense.

So it probably makes sense to drop the enum too.

@foxycode foxycode mentioned this pull request Mar 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants