Drop DqlSelection and Dql namespace #256
Conversation
|
@fprochazka This one should be finished too. |
|
@fprochazka Rebased from master |
| /** | ||
| * @author Filip Procházka <[email protected]> | ||
| */ | ||
| class InlineParamsBuilder extends Kdyby\Doctrine\QueryBuilder |
There was a problem hiding this comment.
do not remove this one please
There was a problem hiding this comment.
@fprochazka You wanted to remove whole Dql namespace. Where should I move it then?
There was a problem hiding this comment.
Yeah I know, but I forgot about this one. Just leave it as is for now please.
|
@fprochazka Updated as you wanted. I renamed |
|
@foxycode well, how many people are extending tests and how many people are extending classes that are part of a library? I don't think renaming the class is a good idea at this point. |
|
I do agree that is probably a better name, but I don't wanna think about it now and introduce more BC Breaks than neccesary. |
|
@fprochazka Ok, should I rename test then or leave it as is? |
|
Also, by renaming the class, you're combining two unrelated changes in one PR. |
|
Please revert the rename. It is not neccesary right now nor related. |
|
@fprochazka Done |
Drop DqlSelection and Dql namespace
|
@foxycode thank you! :) |
|
Again: if anybody was using it, you're welcome to create a new package with this (or better) code that implements it. |
Related to #238