Evaluated Kdyby_Doctrine_IamTheKingOfHackingNette_* removed #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| $this->map = $this->cache->load($containerFile); | ||
|
|
||
| if ($this->map === NULL) { | ||
| foreach ($queue as $manager => $items) { |
There was a problem hiding this comment.
This is extracted code from OrmExtension with minor changes
($config = $this->managerConfigs[$manager]; -> $repository = $classNames[$manager];).
hranicka
force-pushed
the
feature/dic-hacking
branch
from
9521c1d
to
ebf6fe1
Compare
|
Tests failing on Nette 2.3-dev because of this. |
|
Wow, this is a big change. But... I've come to a conclusion, that this magic for the repositories is wrong :) So I'm gonna be removing it entirely in I'm not sure I wanna be changing this in |
hranicka
force-pushed
the
feature/dic-hacking
branch
from
f6bc97d
to
b898a28
Compare
|
You should bypass the magic by declaring the metadata it tries to read from "runtime" by compiling the container. This is going to be removed from Kdyby. |
|
Sorry, but I can't merge this, as it would complicate the process for me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Filip,
First, thank you for a great Nette extension Kdyby/Doctrine!
But I've got some kind of problems when I register a repository as a service (i.e. in a config file).
The reason is DIC is evaluated at a compile time here.
The problem is that some code is lauchned twice (i.e. Kdyby\Events Tracy Panel registration).
It's a problem only at a compile-time, but I've had another issue and my DIC was rebuilt for every application request (in a debug mode only).
I've refactored the code and removed DIC evaluating at a compile-time.
Because there are some expensive operations and now the code is launched at a run-time, I've added caching in there.
Now the code in a production should be as fast as previously (DIC evaluating and generated PHP class changes vs. repository mapping and caching the map). And DIC is evaluated as should be - only at runtime.
What do you think?