Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node selection after loading a proof #3297

Open
unp1 opened this issue Oct 13, 2023 · 4 comments
Open

Node selection after loading a proof #3297

unp1 opened this issue Oct 13, 2023 · 4 comments
Assignees
Labels

Comments

@unp1
Copy link
Member

unp1 commented Oct 13, 2023

Description

Loading an open proof selects the root node instead of an open goal.
I am not sure if that may be intended behavior, because one can be of course the
opinion that this is the better way.

In any case, for teaching I sometimes load proofs that have just one branch open and before that branch would be
directly selected, which makes the workflow a bit easier.

In any case, if the change was intended, please close the bug with won't fix.

Reproducible

always

Steps to reproduce

Describe the steps needed to reproduce the issue.

  1. Save an open proof (with on goal open)
  2. Load the proof
  3. Root is selected after loading

My expectation would be that the open goal is selected.

Additional information

Add more details here. In particular: if you have a stacktrace, put it here.


@FliegendeWurst
Copy link
Member

I agree that selecting an open goal is more useful than selecting the root node. Don't know why it was changed.
I think the fix would be a call to mediator.getSelectionModel().defaultSelection() after loading the proof.

@wadoon
Copy link
Member

wadoon commented Oct 19, 2023

There is an advantage to choose the the root goal initially. On large proofs (highly nested, many nodes), rendering the proof tree takes seconds if you select a nested node.

@unp1
Copy link
Member Author

unp1 commented Oct 27, 2023

Wondering. When saving a proof, we could also store that last selected node (if available) and after loading select this node? So that should be done carefully to not introduce GUI dependencies in ProofSaver

unp1 added a commit that referenced this issue Oct 27, 2023
… selected node in the proof, to reselect it upon loading.
@unp1
Copy link
Member Author

unp1 commented Oct 27, 2023

I submitted PR #3324 for discussion. It adds the mentioned feature.

unp1 added a commit that referenced this issue Oct 27, 2023
… selected node in the proof, to reselect it upon loading.
@unp1 unp1 self-assigned this Oct 27, 2023
unp1 added a commit that referenced this issue Oct 29, 2023
… selected node in the proof, to reselect it upon loading.
unp1 added a commit that referenced this issue Oct 30, 2023
… selected node in the proof, to reselect it upon loading.
unp1 added a commit that referenced this issue Oct 31, 2023
unp1 added a commit that referenced this issue Nov 10, 2023
unp1 added a commit that referenced this issue Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants