-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: If possible save the last selected node in the proof, to reselect it upon loading. #3324
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3324 +/- ##
============================================
- Coverage 37.86% 37.85% -0.01%
- Complexity 16905 16908 +3
============================================
Files 2055 2055
Lines 125528 125553 +25
Branches 21226 21237 +11
============================================
+ Hits 47525 47528 +3
- Misses 72152 72171 +19
- Partials 5851 5854 +3 ☔ View full report in Codecov by Sentry. |
c7d4b8b
to
ed6f332
Compare
…elect it upon loading (issue #3297).
Why does this have so many changed files. This should rather be a local feature. Is it not possible to use the local settings, instead of the proof replayer? |
The amount of files is just because we need to pass the selected node to the proof saver.
Sadly not as we do no save unique node identifiers in our proofs and the node numbers upon reload may differ (e.g. when the proof was pruned at some point). |
Sarah and I have used a slightly different system to identify nodes uniquely. We used the path from root to the node in the same manner as PiO and PiS. See here. Of course, if you apply run-length encoding you can save a lot of entries in the list (mostly zero, and some ones). |
I close this PR as we will fix the issue using #3380 |
This commit addresses issue #3297.