Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: If possible save the last selected node in the proof, to reselect it upon loading. #3324

Closed
wants to merge 1 commit into from

Conversation

unp1
Copy link
Member

@unp1 unp1 commented Oct 27, 2023

This commit addresses issue #3297.

@unp1 unp1 linked an issue Oct 27, 2023 that may be closed by this pull request
@unp1 unp1 changed the title This commit addresses issue #3297. Feature: If possible save the last selected node in the proof, to reselect it upon loading. Feature: If possible save the last selected node in the proof, to reselect it upon loading. Oct 27, 2023
@unp1 unp1 self-assigned this Oct 27, 2023
@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

Attention: 40 lines in your changes are missing coverage. Please review.

Comparison is base (ac66700) 37.86% compared to head (638e108) 37.85%.

Files Patch % Lines
...of/io/IntermediatePresentationProofFileParser.java 31.25% 11 Missing ⚠️
.../uka/ilkd/key/proof/io/OutputStreamProofSaver.java 25.00% 8 Missing and 1 partial ⚠️
...a/ilkd/key/proof/io/IntermediateProofReplayer.java 33.33% 5 Missing and 1 partial ⚠️
...e/uka/ilkd/key/proof/io/AbstractProblemLoader.java 37.50% 2 Missing and 3 partials ⚠️
...key/proof/io/intermediate/AppNodeIntermediate.java 33.33% 4 Missing ⚠️
...ore/src/main/java/de/uka/ilkd/key/proof/Proof.java 0.00% 2 Missing ⚠️
...main/java/de/uka/ilkd/key/proof/io/ProofSaver.java 60.00% 2 Missing ⚠️
.../main/java/de/uka/ilkd/key/proof/io/AutoSaver.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3324      +/-   ##
============================================
- Coverage     37.86%   37.85%   -0.01%     
- Complexity    16905    16908       +3     
============================================
  Files          2055     2055              
  Lines        125528   125553      +25     
  Branches      21226    21237      +11     
============================================
+ Hits          47525    47528       +3     
- Misses        72152    72171      +19     
- Partials       5851     5854       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@FliegendeWurst FliegendeWurst added GUI RFC "Request for comments" is the appeal for making and expressing your opinion on a topic. labels Oct 27, 2023
@unp1 unp1 force-pushed the issue3297 branch 3 times, most recently from c7d4b8b to ed6f332 Compare October 31, 2023 07:25
@wadoon
Copy link
Member

wadoon commented Dec 3, 2023

Why does this have so many changed files. This should rather be a local feature.

Is it not possible to use the local settings, instead of the proof replayer?

@unp1
Copy link
Member Author

unp1 commented Dec 4, 2023

Why does this have so many changed files. This should rather be a local feature.

The amount of files is just because we need to pass the selected node to the proof saver.

Is it not possible to use the local settings, instead of the proof replayer?

Sadly not as we do no save unique node identifiers in our proofs and the node numbers upon reload may differ (e.g. when the proof was pruned at some point).

@wadoon
Copy link
Member

wadoon commented Dec 7, 2023

Sadly not as we do no save unique node identifiers in our proofs and the node numbers upon reload may differ (e.g. when the proof was pruned at some point).

Sarah and I have used a slightly different system to identify nodes uniquely. We used the path from root to the node in the same manner as PiO and PiS. See here. Of course, if you apply run-length encoding you can save a lot of entries in the list (mostly zero, and some ones).

@unp1
Copy link
Member Author

unp1 commented Feb 22, 2024

I close this PR as we will fix the issue using #3380

@unp1 unp1 closed this Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GUI RFC "Request for comments" is the appeal for making and expressing your opinion on a topic.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Node selection after loading a proof
3 participants