Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alternative for: "If possible save the last selected node in the proof, to reselect it upon loading." #3380

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

wadoon
Copy link
Member

@wadoon wadoon commented Dec 28, 2023

Alternative version for #3324 using the settings instead of storing it in the proof.

Using a path encoding of the current node (list of child indexes) and a run-length encoding to keep it small.

Missing: Finding the right spot where the KeYUserProblemFile is available and the proof is loaded. The current place is unsuitable.

@wadoon wadoon requested a review from unp1 December 28, 2023 04:13
@KeYProject KeYProject deleted a comment from codecov bot Feb 3, 2024
* origin/main: (25 commits)
  Bump com.diffplug.spotless from 6.24.0 to 6.25.0
  Bump com.diffplug.spotless from 6.23.3 to 6.24.0
  Bump org.slf4j:slf4j-api from 2.0.10 to 2.0.11
  Bump org.slf4j:slf4j-api from 2.0.9 to 2.0.10
  spotless reformat
  automatical translate package.html to package-info.java
  spotless
  after discussion: all datatypes are free
  ignore files in */antlr4/gen/*
  Treat duplicate predicate declarations as error.
  adding example file for natural numbers as ADTs
  Fix TestTermParser to avoid multiple parsing of declarations
  implement the discussion of KaKeY
  spotless
  fix merge errors
  fix passing of warnings
  no spaces in displaynames of taclets
  fix spaces in origin label manually + spotless
  add an example for case distinction
  add list example with two proofs
  ...

# Conflicts:
#	key.core/src/main/java/de/uka/ilkd/key/nparser/KeyAst.java
@wadoon wadoon marked this pull request as ready for review February 3, 2024 16:47
@wadoon
Copy link
Member Author

wadoon commented Feb 3, 2024

@unp1 I now call getMediator().nonGoalChosen(node) with a valid node, but it is not selected. Where is the other place with the logic that the last node should be taken?

@KeYProject KeYProject deleted a comment from codecov bot Feb 3, 2024
Copy link

codecov bot commented Feb 3, 2024

Codecov Report

Attention: 42 lines in your changes are missing coverage. Please review.

Comparison is base (603b2ca) 37.93% compared to head (66b0aa4) 37.93%.

Files Patch % Lines
.../uka/ilkd/key/proof/io/OutputStreamProofSaver.java 25.00% 14 Missing and 1 partial ⚠️
...core/src/main/java/de/uka/ilkd/key/proof/Node.java 0.00% 12 Missing ⚠️
...n/java/de/uka/ilkd/key/settings/Configuration.java 9.09% 10 Missing ⚠️
...uka/ilkd/key/macros/scripts/ProofScriptEngine.java 0.00% 2 Missing ⚠️
.../src/main/java/de/uka/ilkd/key/nparser/KeyAst.java 90.90% 1 Missing ⚠️
...de/uka/ilkd/key/proof/init/KeYUserProblemFile.java 75.00% 0 Missing and 1 partial ⚠️
...n/java/de/uka/ilkd/key/settings/ProofSettings.java 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##               main    #3380    +/-   ##
==========================================
  Coverage     37.93%   37.93%            
- Complexity    17030    17038     +8     
==========================================
  Files          2060     2060            
  Lines        126300   126409   +109     
  Branches      21304    21324    +20     
==========================================
+ Hits          47913    47958    +45     
- Misses        72499    72560    +61     
- Partials       5888     5891     +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant