-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
One Step Simplifier: optimizations and new rules #3272
Open
FliegendeWurst
wants to merge
15
commits into
KeYProject:main
Choose a base branch
from
FliegendeWurst:ossOptimize
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FliegendeWurst
force-pushed
the
ossOptimize
branch
from
September 5, 2023 12:46
3927320
to
0ef0414
Compare
Codecov Report
@@ Coverage Diff @@
## main #3272 +/- ##
=========================================
Coverage 37.74% 37.74%
- Complexity 16851 16867 +16
=========================================
Files 2052 2052
Lines 125687 125754 +67
Branches 21234 21254 +20
=========================================
+ Hits 47436 47463 +27
- Misses 72408 72432 +24
- Partials 5843 5859 +16
... and 12 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more 📢 Have feedback on the report? Share it here. |
FliegendeWurst
changed the title
One Step Simplifier: several optimizations
One Step Simplifier: optimizations and new rules
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #3248 and supersedes #3256 and #3257 by optimizing the One Step Simplifier in several ways. See the commits in this branch for details.
Additionally, the following rules are added to a new
oss
ruleset included in the OSS:This means that the One Step Simplifier can now simplify many heap terms in a single step. Previously this required many more proof nodes. For the file linked below, this additional ruleset is required (see #3248 (comment)). The ruleset is handled specially in the Simplifier so it will not be applied inside a Quantifier, seqDef Function or UpdateJunctor (essentially it should only simplify heap selects where every parameter is known).
See #3280 for benchmarks on the optimizations.
When adding the new rules, the OSS can do much more, but does not need much more time. Thanks to the optimization of the cycle check, its impact is not very high.
cc @WolframPfeifer @mattulbrich