-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow realizing multiple cached branches at once #3440
base: main
Are you sure you want to change the base?
Allow realizing multiple cached branches at once #3440
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3440 +/- ##
============================================
- Coverage 37.86% 37.85% -0.02%
+ Complexity 17079 17043 -36
============================================
Files 2092 2082 -10
Lines 127596 127299 -297
Branches 21478 21442 -36
============================================
- Hits 48316 48184 -132
+ Misses 73355 73202 -153
+ Partials 5925 5913 -12 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This feature worked for me during review. Thanks! However, the user feedback should be improved a bit in my opinion: I nearly always get a dialog listing (only) the nodes where the caching failed (in the screenshot, actually two of the three goals are closed via cache):
A bit unrelated, I have another small feature request: "Prune Proof" should work with goals that are closed by cache. At the moment, I have to click on "Proof caching" -> "Re-open cached goal", which is a bit cumbersome. From a user point of view, both are the same operation (cutting away proof nodes).
I changed this dialog to list both successful matches and mismatches.
Done |
Intended Change
This PR changes the "Copy referenced proof steps here" action to allow applying it on any node that has leaf children with caching info.
It will then copy the referenced proof steps for all cached branches.
Type of pull request
Ensuring quality
Additional information and contact(s)
The contributions within this pull request are licensed under GPLv2 (only) for inclusion in KeY.