-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-enable sonarqube for quality assessment #3488
Conversation
a1de31c
to
d66075b
Compare
d66075b
to
82ef399
Compare
I added this branch to some of PR to test the analysis:
So we can investigate the difference analyses. |
Quality Gate passedIssues Measures |
* also fix some encoding in recorder/src files # Conflicts: # .github/workflows/code_quality.yml # build.gradle
04dbc1a
to
d5992f3
Compare
I don't think that this PR matches our conclusion from the KaKeY. At least for spotless, I think we agreed that we want to keep it (can be read between the lines here https://git.key-project.org/key/key/-/wikis/KaKeY/KaKeY-2024-10-25). Also, I think we agreed to remove Qodana, CodeQL, and PMD. But I am not sure (and did also not find anything in the logs) about a decision for Checkstyle and Sonarcloud ... Did I miss something? |
Quality Gate passedIssues Measures |
Issue
As discussed in the kakey meetting, the current situation of the quality assessment tool is rather unsatisfying. This PR removes the current tools (pmd, checkstyle, qodana, codeql) in favor sonarqube (again).
Intended Change
Integration of sonarqube. Removal of the rest.
Type of pull request
Ensuring quality