Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable sonarqube for quality assessment #3488

Merged
merged 2 commits into from
Nov 22, 2024
Merged

Re-enable sonarqube for quality assessment #3488

merged 2 commits into from
Nov 22, 2024

Conversation

wadoon
Copy link
Member

@wadoon wadoon commented Jun 21, 2024

Issue

As discussed in the kakey meetting, the current situation of the quality assessment tool is rather unsatisfying. This PR removes the current tools (pmd, checkstyle, qodana, codeql) in favor sonarqube (again).

Intended Change

Integration of sonarqube. Removal of the rest.

Type of pull request

  • maintenance

Ensuring quality

  • inspecting sonarqube
  • trusting sonarqube

@wadoon wadoon changed the title reenable sonarqube, disable the crappy things Re-enable sonarqube for quality assessment Jun 23, 2024
@wadoon
Copy link
Member Author

wadoon commented Jun 25, 2024

Copy link

sonarcloud bot commented Jun 25, 2024

* also fix some encoding in recorder/src files

# Conflicts:
#	.github/workflows/code_quality.yml
#	build.gradle
@WolframPfeifer
Copy link
Member

I don't think that this PR matches our conclusion from the KaKeY. At least for spotless, I think we agreed that we want to keep it (can be read between the lines here https://git.key-project.org/key/key/-/wikis/KaKeY/KaKeY-2024-10-25).

Also, I think we agreed to remove Qodana, CodeQL, and PMD. But I am not sure (and did also not find anything in the logs) about a decision for Checkstyle and Sonarcloud ... Did I miss something?

Copy link

sonarcloud bot commented Nov 22, 2024

@wadoon wadoon added this pull request to the merge queue Nov 22, 2024
@wadoon wadoon removed this pull request from the merge queue due to a manual request Nov 22, 2024
@wadoon wadoon added this pull request to the merge queue Nov 22, 2024
Merged via the queue into main with commit 9b32d97 Nov 22, 2024
9 checks passed
@wadoon wadoon deleted the weigl/codequality branch November 22, 2024 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants