Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restoration of the formatter for KEY files #3494

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Conversation

wadoon
Copy link
Member

@wadoon wadoon commented Jul 6, 2024

Archeology: In the back old days, we reformatted all our KeY files.

If you need to restore a branch before that time to bring it on the master, you should also reformat the KeY files before the merging.

This PR brings the formatter written by Wiesler.

The original MR was !614.

Currently unclear, whether we want to bring this on the main.

Has Sonarqube activated for evaluation reason

  • Missing for main
    • Test cases

@wadoon wadoon requested a review from mattulbrich July 6, 2024 12:28
@wadoon wadoon self-assigned this Jul 6, 2024
@mattulbrich
Copy link
Member

Achieving auto-formatting for .key files would be nice since we have the infrastructure for this ...

Copy link
Member

@mattulbrich mattulbrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no documentation / commenting at all.

Copy link

sonarcloud bot commented Aug 4, 2024

# By Mattias Ulbrich (15) and others
# Via GitHub (21) and others
* origin/main: (36 commits)
  Bump the github-actions-deps group with 2 updates
  Bump the gradle-deps group with 5 updates
  formatting
  Bump the github-actions-deps group with 2 updates
  Bump the gradle-deps group with 8 updates
  spotless
  generating ProofTree tooltips lazily, options to disable them completely
  fix for visual bug with overlapping/unreadable text in color settings
  Fox copyright year
  Bump the gradle-deps group with 6 updates
  improving code for heatmap activation
  applied spotless
  Missed nonnullness of map keys.
  type annotations for test cases
  repairing a nullness type error
  some more NonNull annotations
  Adding a test case for immutable maps.
  extending the nonnull type system to the immutable maps
  repairing type annotations in key.util ... it compiles again.
  repairing heatmap updates for inner nodes
  ...

# Conflicts:
#	build.gradle
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants