Remove version lock for JDT in spotless #3498
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wadoon
added
the
🛠 Maintenance
wadoon
force-pushed
the
weigl/spotlessjdtversion
branch
from
78d7608
to
8c12755
Compare
wadoon
force-pushed
the
weigl/spotlessjdtversion
branch
from
8c12755
to
c150fca
Compare
wadoon
force-pushed
the
weigl/spotlessjdtversion
branch
from
c150fca
to
e44c969
Compare
There was a problem hiding this comment.
I agree that since the eclipse formatter does not crash any more with the newer version, we can remove the version lock. The change with the indentation in a few places is good. However, I don't think we should reformat the code inside <pre> tags in JavaDoc. Is there are way to switch that off?
wadoon
force-pushed
the
weigl/spotlessjdtversion
branch
from
e44c969
to
e3b5cc1
Compare
wadoon
force-pushed
the
weigl/spotlessjdtversion
branch
from
e3b5cc1
to
9a88c26
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the version lock for JDT in the spotless configurations, b/c the new version can handle all classes w/o error.
Also, apply spotless to the code basis. It seems, that Java in Javadoc is also formatted.