Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for visual bug with overlapping/unreadable text in color settings #3509

Merged
merged 3 commits into from
Sep 2, 2024

Conversation

WolframPfeifer
Copy link
Member

This PR fixes a visual bug in the Options dialog when changing the colors.
The bug was originally discovered by @BookWood7th (on Windows, but I think that is irrelevant), who also provided this screenshot that shows the problem:

Screenshot 2024-08-23 142549

Intended Change

  • Fix of the visual bug where during editing of a color text field, the text gets unreadable and weirdly overlaps. The fix was to set the field to transparent. I do not know why it works, but somehow opaque components do not work correctly with background colors that also contain alpha.
  • Fix: For the preview icons besides the color (in non-edited cells), the alpha channel was not correctly interpreted: It seems that it was interpreted as if the background was black. When merged with the non-alpha part, it resulted in colors that are usually not shown in the GUI (since the background color is not black there). Now, background is interpreted as white, which is much better in my opinion (compare for instance the first two colors between the screenshots: they represent the same color code!).

New screenshot with the fix:
image

Type of pull request

  • Bug fix (non-breaking change which fixes an issue)
  • Refactoring (behaviour should not change or only minimally change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • There are changes to the (Java) code
  • There are changes to the taclet rule base
  • There are changes to the deployment/CI infrastructure (gradle, github, ...)
  • Other:

Ensuring quality

  • I made sure that introduced/changed code is well documented (javadoc and inline comments).
  • I made sure that new/changed end-user features are well documented (https://github.com/KeYProject/key-docs).
  • I added new test case(s) for new functionality.
  •  I have tested the feature as follows: Manual inspection in GUI.
  • I have checked that runtime performance has not deteriorated.

The contributions within this pull request are licensed under GPLv2 (only) for inclusion in KeY.

@WolframPfeifer
Copy link
Member Author

@BookWood7th Could you maybe check whether this fixes the bug also on Windows?

@WolframPfeifer
Copy link
Member Author

Thanks for approving. I also got the confirmation by @BookWood7th that it fixes the original bug.

@WolframPfeifer WolframPfeifer added this pull request to the merge queue Sep 2, 2024
Merged via the queue into main with commit 0fda856 Sep 2, 2024
12 of 13 checks passed
@WolframPfeifer WolframPfeifer deleted the pfeifer/colorSettingsRepaintBug branch September 2, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants