Parse string escape sequences #16

Arnaz87 · 2019-01-29T20:18:03Z

Fixes #10

Keats · 2019-01-31T19:00:31Z

README.md

@@ -95,7 +95,7 @@ They are surrounded by double quotes:
 ```
 str = "The dog says \"woof\"."
 ```
-As you can see, double quotes have to be escaped if used in basic strings.
+As you can see, double quotes have to be escaped if used in basic strings. Valid escape secuences are quotes with `\"`, newlines with `\n` and two digit hexadecimal characters with `\x00`.


Keats · 2019-01-31T19:02:36Z

parser/src/parser.rs

+    }
+
+    result
+}


This function will need to return a Result seeing the number of things that can panic, unless they are all cases prevented by the parser.

Parse string escape sequences

6c1c571

Keats requested changes Jan 31, 2019

View reviewed changes

Better error handling in escape_string

5ba7cd8

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Parse string escape sequences #16

Parse string escape sequences #16

Arnaz87 commented Jan 29, 2019

Keats Jan 31, 2019

Keats Jan 31, 2019

+                  }
+                  result
+              }

Parse string escape sequences #16

Are you sure you want to change the base?

Parse string escape sequences #16

Conversation

Arnaz87 commented Jan 29, 2019

Keats Jan 31, 2019

Choose a reason for hiding this comment

Keats Jan 31, 2019

Choose a reason for hiding this comment