Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove error-chain #352

Merged
merged 1 commit into from
Nov 10, 2018
Merged

remove error-chain #352

merged 1 commit into from
Nov 10, 2018

Conversation

andy128k
Copy link
Contributor

@andy128k andy128k commented Nov 7, 2018 •
edited
Loading

Addresses #297

@Keats
Copy link
Owner

Keats commented Nov 8, 2018

Amazing, thanks!
The CI failure is due to the addition of source in Error (:walking_man:) which is only stable since 1.30 so that raises the min version of Tera to 1.30, which is fine.

I will review the changes tomorrow or this weekend, thanks again!

@Keats Keats changed the base branch from master to v1 November 9, 2018 16:24
@Keats Keats merged commit 39e04c8 into Keats:v1 Nov 10, 2018
@Keats
Copy link
Owner

Keats commented Nov 10, 2018

Thanks again!

@andy128k andy128k deleted the remove-error-chain branch November 12, 2018 12:13
@Keats
Copy link
Owner

Keats commented Nov 12, 2018

Playing with it locally it looks like we still need to impl Iterate on the Error somehow but otherwise it works fine!

@Keats
Copy link
Owner

Keats commented Nov 12, 2018

Added the iteration on the v1 branch so it should be fine!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andy128k @Keats