-
Notifications
You must be signed in to change notification settings - Fork 897
Programmable block better exception handling #537
base: master
Are you sure you want to change the base?
Programmable block better exception handling #537
Conversation
Added the Scripts StackTrace when an Exception is thrown by the Script, removing all internal calls leading to the Scripts Call.
Do you have a screenshot showing what the exception text looks like with these changes? |
No because the VRage.Game (MyModel.cs and MyPhysicsComponent.cs) and VRage.Network (MyRakNet... .cs) have compilation Errors ... Leading to more Errors because VRage.Game.dll and VRage.Network.dll are missing after these ... BUT the Output should look like a normal StackTrace of C# |
"Should" doesn't get merged. You need to test your code and prove that it works with no bad side effects. There are guides on the forums on how to tweak the source to compile in x64. |
Seems you haven't been active for 3 months now here in this gitHub Repository ... |
Dude, you don't even know if this code works or not. You don't even know if it compiles. |
Environment.StaceTrace returns the stack trace of where that property was called at. It is not the same as the exception stack trace. I'm not sure how that's useful here, while the original is not. |
@Pingger My last comment in this repository was four days ago and the source was last updated nine days ago. Since you've decided to start freaking out I'm far less inclined to help you get your code into the game, sorry. |
I know that Environment.StaceTrace is for the current position and it is suppoed to. so I can filter SpaceEngineers calls from Script calls! As stated in the comments. |
Ah ok. |
Changed string to StringBuilder so less allocations are made when "replacing" (deleting) the internal calls
I just managed to get SE to launch (I had to resolve 13 errors in RakNet ... I simply put // infront of each line) |
Any way to get the exception name in there? |
Hi,
Because I hated those simple "an exception occured" messages and always wanted to know where exactly the Exception occurd, I added the Scripts StackTrace to the DetailedInfo, so the Programmer knows where to search for the Problem.
These are the CodeChanges:
TestCode:
This is my first .NET programming I have ever made, so feel free to give feedback about my changes. Before I programmed in Java and Scripted in SpaceEngineers.
Greetings
Pingger
Edit: Clarified what the code does ...