Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REFACTOR] 마이 페이지 수정 #133

Merged
merged 5 commits into from
Nov 22, 2024
Merged

[REFACTOR] 마이 페이지 수정 #133

merged 5 commits into from
Nov 22, 2024

Conversation

kimeodml
Copy link
Collaborator

What is this PR? 🔍

Changes 📝

  • 마이페이지 반응형으로 수정했습니다.

ScreenShot 📷

Nov-21-2024 18-32-52

Precaution

✔️ Please check if the PR fulfills these requirements

  • It's submitted to the correct branch, not the develop branch unconditionally?
  • If on a hotfix branch, ensure it targets main?
  • There are no warning message when you run npm run lint

Copy link
Collaborator

@haejinyun haejinyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

찜도 아무것도 없을 때는 거래 내역과 동일한 레이아웃 맞춰주면 좋을 것 같아요.
그리고 ListLayout에도 반응형으로 모바일일때의 디자인 대응이 들어가야할 것 같아요 이 wrapper로 레이아웃이 깨지는 것 같네요..

QA문서에 올라온것 확인 하고 반영 부탁드립니다!

},
},
});

export const bidTitle = style({
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

여기가 지금 140px로 잡혀있는데 이걸 max 140px으로 두고 width는 100%로 줘야할 것 같아요
끝이 좀 짤리네요

Copy link
Collaborator

@haejinyun haejinyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수정된거 확인 했습니다!
그런데 전체적으로 마이페이지의 각 요소들의 padding이 안맞는 것 같아서 그것만 일정하게 하면 될 것 같아요~ 어프룹 할게요!

@kimeodml kimeodml merged commit 88f8a0b into develop Nov 22, 2024
2 checks passed
@kimeodml kimeodml deleted the feat/#126 branch November 22, 2024 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[REFACTOR] 마이 페이지 반응형으로 변경
2 participants