👷 ci(package name): ubuntu to linux

KevinNitroG · Jun 7, 2024 · 17f949d · 17f949d
1 parent 6c7fa44
commit 17f949d
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 5 deletions.
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -44,6 +44,10 @@ jobs:
     timeout-minutes: 10
     if: ${{ needs.prepare.outputs.CONTINUE == 'true' }}
     steps:
+      - name: get OS lowercase
+        id: get_os
+        run: echo "OS_LOWER=${RUNNER_OS,,}" >> $GITHUB_ENV
+
       - name: Checkout repo
         uses: actions/checkout@main
 
@@ -56,8 +60,8 @@ jobs:
       - name: Install dependacies
         run: pip install -r requirements/requirements.txt && pip install pyinstaller
 
-      - name: Build for ${{ matrix.os }}
-        run: pyinstaller --noconfirm --onefile --console --icon "assets/images/VNU_HCM_LOGO-256.ico" --name "VNULIB-Downloader-${{ matrix.os }}" --log-level "INFO" --add-data "src/:src/" --add-data "config-sample.yml:." --add-data "assets/images/error_page.jpg:assets/images/" --add-data "assets/utils/ascii_banner.txt:assets/utils/" --add-data "LICENSE:." --collect-data grapheme "main.py"
+      - name: Build for ${{ runner.os }}
+        run: pyinstaller --noconfirm --onefile --console --icon "assets/images/VNU_HCM_LOGO-256.ico" --name "VNULIB-Downloader-${{ env.OS_LOWER }}" --log-level "INFO" --add-data "src/:src/" --add-data "config-sample.yml:." --add-data "assets/images/error_page.jpg:assets/images/" --add-data "assets/utils/ascii_banner.txt:assets/utils/" --add-data "LICENSE:." --collect-data grapheme "main.py"
 
       - name: Change permissions
         if: runner.os == 'Linux' || runner.os == 'macOS'
@@ -66,7 +70,7 @@ jobs:
       - name: Upload to artifact
         uses: actions/upload-artifact@main
         with:
-          name: VNULIB-Downloader-${{ matrix.os }}
+          name: VNULIB-Downloader-${{ env.OS_LOWER }}
           path: dist/VNULIB-Downloader-*
           compression-level: 6
           retention-days: 30

diff --git a/docs/README.md b/docs/README.md
@@ -100,7 +100,7 @@ Python CLI tool download sách từ <strong>VNULIB</strong>
 
 - [![Windows](https://img.shields.io/badge/Windows-8aadf4?style=for-the-badge&logo=windows&logoColor=white)](https://github.com/KevinNitroG/VNULIB-Downloader/releases/latest/download/VNULIB-Downloader-windows.exe)
 - [![Mac OS](https://img.shields.io/badge/MAC_OS-ed8796?style=for-the-badge&logo=apple&logoColor=white)](https://github.com/KevinNitroG/VNULIB-Downloader/releases/latest/download/VNULIB-Downloader-macos)
-- [![Linux](https://img.shields.io/badge/Linux-5b6078?style=for-the-badge&logo=linux&logoColor=white)](https://github.com/KevinNitroG/VNULIB-Downloader/releases/latest/download/VNULIB-Downloader-ubuntu)
+- [![Linux](https://img.shields.io/badge/Linux-5b6078?style=for-the-badge&logo=linux&logoColor=white)](https://github.com/KevinNitroG/VNULIB-Downloader/releases/latest/download/VNULIB-Downloader-linux)
 
 > [!NOTE]
 >
@@ -184,7 +184,7 @@ Python CLI tool download sách từ <strong>VNULIB</strong>
   ```
 - Linux:
   ```sh
-  ./VNULIB-Downloader-ubuntu --help
+  ./VNULIB-Downloader-linux --help
   ```
 - Ví dụ _(Windows)_:
   ```.ps1