Change options_page back to options_ui in manifest

options_page is apparently deprecated in Firefox
Khan · Dec 9, 2019 · 37d259d · 37d259d
1 parent 51e074f
commit 37d259d
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 3 deletions.
diff --git a/manifest.json b/manifest.json
@@ -7,13 +7,17 @@
     "activeTab",
     "storage"
   ],
-  "options_page": "options.html",
   "web_accessible_resources": [
     "5commastyle.gif"
   ],
   "background": {
     "scripts": ["background.js"],
     "persistent": true
+  },
+   "options_ui": {
+    "page": "options.html",
+    "open_in_tab": true,
+    "browser_style": true
   },
   "content_scripts": [
     {

diff --git a/options.html b/options.html
@@ -5,9 +5,9 @@
    <title>KhanAcademyDots Math Translations</title></head>
 <body>
 
-  <h1>KhanAcademyDots plugin for automatic translations of math notation</h1>
+  <h2>KhanAcademyDots plugin for automatic translations of math notation</h2>
 
-  <h2>Please select your language for Khan Academy translations</h2>
+  <h3>Please select your language</h3>
 
 <select id="locale">
  <option value="sq">Albanian</option>

diff --git a/pack_plugin.sh b/pack_plugin.sh
@@ -51,6 +51,7 @@ if [[ $browser = 'chrome' ]];then
   grep -v -e gecko -e browser_specific_settings manifest.json > tmp
   # More chrome specific things
   sed -i 's/"persistent": true/"persistent": false/' tmp
+  sed -i 's/browser_style/chrome_style/' tmp
   mv tmp manifest.json
 fi
 zip -r $PACKAGE_NAME.zip *