Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test parallel compilation of many small programs. #3597

Merged
merged 1 commit into from
Oct 10, 2023
Merged

Test parallel compilation of many small programs. #3597

merged 1 commit into from
Oct 10, 2023

Conversation

kenrussell
Copy link
Member

No description provided.

@kenrussell
Copy link
Member Author

Stresses a code path in Chromium that wasn't easily exercised.

@kenrussell kenrussell merged commit b9be8f8 into KhronosGroup:main Oct 10, 2023
1 check passed
@kenrussell kenrussell deleted the lots-of-programs branch October 10, 2023 20:11
aarongable pushed a commit to chromium/chromium that referenced this pull request Oct 11, 2023
@kenrussell
Rewrite program completion map in terms of GC'd data structures.
b427192 
Since there is no HeapLinkedHashMap yet, maintain the program
completion query map with a combined HeapHashMap mapping programs to
their completion queries, and a HeapVector which maintains the
ordering of additions to the map.

Stress this revised code path with an enhancement to the
KHR_parallel_shader_compile conformance test
KhronosGroup/WebGL#3597 .

Verified (via printfs, while running the new test) that the lookups
using Member<WebGLProgram> are working as expected.

Fixed: 1472363
Change-Id: Ib23b4b2cfce5ae9100c073b21808fdbffc3453a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4924343
Reviewed-by: Michael Lippautz <[email protected]>
Reviewed-by: Omer Katz <[email protected]>
Commit-Queue: Kenneth Russell <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1207997}
aarongable pushed a commit to chromium/chromium that referenced this pull request Oct 12, 2023
@kenrussell
Revert "Rewrite program completion map in terms of GC'd data structur…
821befd 
…es."

This reverts commit b427192.

Reason for revert: caused crashes, crbug.com/1491984

Original change's description:
> Rewrite program completion map in terms of GC'd data structures.
>
> Since there is no HeapLinkedHashMap yet, maintain the program
> completion query map with a combined HeapHashMap mapping programs to
> their completion queries, and a HeapVector which maintains the
> ordering of additions to the map.
>
> Stress this revised code path with an enhancement to the
> KHR_parallel_shader_compile conformance test
> KhronosGroup/WebGL#3597 .
>
> Verified (via printfs, while running the new test) that the lookups
> using Member<WebGLProgram> are working as expected.
>
> Fixed: 1472363
> Change-Id: Ib23b4b2cfce5ae9100c073b21808fdbffc3453a8
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4924343
> Reviewed-by: Michael Lippautz <[email protected]>
> Reviewed-by: Omer Katz <[email protected]>
> Commit-Queue: Kenneth Russell <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1207997}

Bug: 1472363, 1491984
Change-Id: I37179a3cb96fb1aa926c6b64d987ef36151462d2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4935614
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Auto-Submit: Kenneth Russell <[email protected]>
Owners-Override: Srinivas Sista <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1209006}
aarongable pushed a commit to chromium/chromium that referenced this pull request Jan 27, 2024
@kenrussell
Reland "Rewrite program completion map in terms of GC'd data structur…
2b4800a 
…es."

This is a reland of commit b427192

This should fix the crash by skipping clearProgramCompletionQueries()
after GC has started destroying the WebGLRenderingContextBase.

Original change's description:
> Rewrite program completion map in terms of GC'd data structures.
>
> Since there is no HeapLinkedHashMap yet, maintain the program
> completion query map with a combined HeapHashMap mapping programs to
> their completion queries, and a HeapVector which maintains the
> ordering of additions to the map.
>
> Stress this revised code path with an enhancement to the
> KHR_parallel_shader_compile conformance test
> KhronosGroup/WebGL#3597 .
>
> Verified (via printfs, while running the new test) that the lookups
> using Member<WebGLProgram> are working as expected.
>
> Fixed: 1472363
> Change-Id: Ib23b4b2cfce5ae9100c073b21808fdbffc3453a8
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4924343
> Reviewed-by: Michael Lippautz <[email protected]>
> Reviewed-by: Omer Katz <[email protected]>
> Commit-Queue: Kenneth Russell <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1207997}

Change-Id: I5ea4102eeff2bb5ba5ff037ba4813c97cbec5340
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5237058
Commit-Queue: Kai Ninomiya <[email protected]>
Reviewed-by: Kenneth Russell <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1253015}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lexaknyazev lexaknyazev lexaknyazev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kenrussell @lexaknyazev